moving failed format tests into their own file#1455
Merged
Conversation
Janther
changed the title
fvictorio
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
following prettier file structure for their tests,
tests/config/run-format-test.jswill slowly get smaller as it currently has a lot of different responsibilities.I decided to do this in smaller reviewable chunks.
Here we move the 3 functions that help decide whether to run or not the second format, AST comparison, and ANTLR format tests to it's own file, making the readability of
tests/config/run-format-test.jsalready much easier.notice how there is a
utilsfolder and autilities.jsfile. Prettier's tests don't have autilsfolder anymore but we are making the migration step by step.